triedb/pathdb: make batch with pre-allocated size #32914
Merged
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Oct 21, 2025
Comment on lines
+163
to
+167
| switch b.typ { | ||
| case typeStateHistory: | ||
| size = estimatedStateHistoryIndexSize | ||
| case typeTrienodeHistory: | ||
| size = estimatedTrienodeHistoryIndexSize |
There was a problem hiding this comment.
no default here? is using 0 future-proof?
There was a problem hiding this comment.
I tracked the use, but I didn't go all the way down. I see pebble uses the size to do something like mallocgc, and then does slice arithmetic on it. I would return a save value just to be sure it doesn't panic.,
There was a problem hiding this comment.
I added the default here. It's only possible to have state history or trienode history, we can panic for unknown type.
There was a problem hiding this comment.
k, I was hoping for a warning, but I agree that this is not a concern right now. It's just the future-proofiness I was considering. Nvm I'll merge.
gballet
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the database batch for writing the history index data is pre-allocated.
It's observed that database batch repeatedly grows the size of the mega-batch,
causing significant memory allocation pressure. This approach can effectively
mitigate the overhead.